Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nick highlighting is a bit weird sometimes #77

Closed
swantzter opened this issue Oct 26, 2020 · 4 comments
Closed

Nick highlighting is a bit weird sometimes #77

swantzter opened this issue Oct 26, 2020 · 4 comments

Comments

@swantzter
Copy link

(like highlighting t in don't)
@glguy
Copy link
Owner

glguy commented Oct 31, 2020

Current behavior is to search for runs of nick-characters in a chat message. I'd be interested in a better algorithm. I want to make sure cases like I heard "glguy was here" to catch glguy.

@swantzter
Copy link
Author

What about requiring 2 or more chars for nick highlighting. Not that many has a one letter nick and they might as well be highlighted with the standard text colour

glguy added a commit that referenced this issue Oct 31, 2020
@glguy
Don't highlight single-letter nicknames in chat messages
3ce618d 
See #77
@glguy glguy closed this as completed Jan 22, 2021
@travankor
Copy link

Isn’t this still an issue if a nick is a substring of a word?

@glguy
Copy link
Owner

glguy commented Jan 23, 2021

No, it only matches whole sequences of nickname characters. exampleglguy wouldn't highlight glguy, for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@glguy @swantzter @travankor