Prevent exception removing class from deleted elements #320
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having an issue trying to destroy a Glide instance when some elements aren't in the DOM anymore.
I'm using AngularJS and I'm rendering the slides and controls dynamically.
After rendering the slides to update the slider, I'm re-creating the Glide to update the slider with the new items, and it was throwing an exception when trying to render fewer items than before.
For example:
I'm using the
glideInstance.destroy()
method to destroy the Glide component.See the exception below:
I hope it can help anyone more.