-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rehydration is adding placeholders tags to the head title tag #796
Comments
Discussed in chat with @kiwiupover, basically the serialization format for: {{#in-element headElement}}
<title>{{someDynamicThing}}</title>
{{/in-element}} Ends up emitting something like: <title><!--%+b:9%-->Some Content<!--%-b:9%--></title> And for |
As a test, I suggested trying: {{{somethingWithTitleTagIncluded}}} Which might force the rendering engine to emit the comment nodes around the title tag (but not inside of it). Obviously, this work around has a number of other significant trade offs but it seemed reasonable to try... |
rehydration in the rcdata state https://dev.w3.org/html5/spec-preview/tokenization.html#rcdata-end-tag-name-state is always going to have this issue |
I think the following should be prefaced with: As I mentioned in ember-fastboot/ember-cli-fastboot#659 (comment), here’s a work-in-progress fix for invalid simple-html-tokenizer: glimmer-vm: |
<title><!--%+b:9%-->RV Rentals from the Most Trusted RV Owners | Outdoorsy<!--%-b:9%--></title>
https://cl.ly/1r3h03190G3x
The text was updated successfully, but these errors were encountered: