Modernize Infrastructure #1418
Merged
Modernize Infrastructure #1418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is currently red until these are merged: https://discord.com/channels/480462759797063690/480502165434138624/1102812603966836837 🙃 |
wycats
force-pushed
the
chore/try-pnpm
branch
6 times, most recently
from
92fb93f
to
bbd5216
Compare
Highlights: - updated `typescript` to `5.0.4`. - updated eslint and associated packages to the latest version - updated prettier and associated packages - updated babel and associated packages - updated to pnpm and pnpm workspaces The biggest consequence of this commit is that packages should *reliably* have dependencies on the packages they depend on. This required moving a handful of interfaces to `@glimmer/interfaces`: - The `Reference` type and associated types - The `Tag` type and associated types - All of the `SimpleDOM` types, to avoid duplication problems Where a symbol is part of an interface, `@glimmer/interface` declares the symbol. The concrete implementation assigns its symbol to the symbol type exported by `@glimmer/interface`. This commit also refactors away from `const enum` in a few key places. Const enums were refactored into normal unions, and the members of a const enum were refactored into type literal types.
wycats
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlights
typescriptto5.0.4.Details
The biggest consequence of this commit is that packages should
reliably have dependencies on the packages they depend on.
This required moving a handful of interfaces to
@glimmer/interfaces:Referencetype and associated typesTagtype and associated typesSimpleDOMtypes, to avoid duplication problemsWhere a symbol is part of an interface,
@glimmer/interfacedeclaresthe symbol. The concrete implementation assigns its symbol to the symbol
type exported by
@glimmer/interface.This commit also refactors away from
const enumin a few key places.Const enums were refactored into normal unions, and the members of a
const enum were refactored into type literal types.