Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlights
execa
,chalk
, etc.initial compilation.
useDefineForClassFields
.Details
We were already relying on TypeScript for first-pass compilation, so the
babel usage was somewhat duplicative and therefore confusing.
The change to
useDefineForClassFields
revealed a ton of fieldsdeclared as
field!: Type
, which meansfield = undefined
in standardJavaScript, and therefore overrides getters, setters or even fields with
initializers defined on any superclass.
This commit changes those fields to
declare field: Type
. Thistranspiles to nothing, leaving any superclass fields alone.
Because the test suite uses Stage 1 decorators, this commit adds back
useDefineForClassFields: false
in the build process. This combinationshould help to detect any reliance on non-standard behavior during type
checking without breaking the current setup.