Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue updating infrastructure #1419

Merged
merged 3 commits into from
May 3, 2023
Merged

Continue updating infrastructure #1419

merged 3 commits into from
May 3, 2023

Conversation

wycats
Copy link
Contributor

@wycats wycats commented May 3, 2023

Highlights

  • Update rollup and associated packages
  • Update broccoli and associated packages
  • Update other node packages like execa, chalk, etc.
  • Update babel usage to use preset-env and rely on TypeScript for the
    initial compilation.
  • Update tsconfig to useDefineForClassFields.

Details

We were already relying on TypeScript for first-pass compilation, so the
babel usage was somewhat duplicative and therefore confusing.

The change to useDefineForClassFields revealed a ton of fields
declared as field!: Type, which means field = undefined in standard
JavaScript, and therefore overrides getters, setters or even fields with
initializers defined on any superclass.

This commit changes those fields to declare field: Type. This
transpiles to nothing, leaving any superclass fields alone.

Because the test suite uses Stage 1 decorators, this commit adds back
useDefineForClassFields: false in the build process. This combination
should help to detect any reliance on non-standard behavior during type
checking without breaking the current setup.

@wycats wycats force-pushed the chore/update-deps branch 2 times, most recently from 0112b97 to 66c4431 Compare May 3, 2023 06:47
@wycats wycats merged commit 78cf7d4 into master May 3, 2023
@wycats wycats deleted the chore/update-deps branch May 3, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants