Fix Signature integration for external consumers
#392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriskrycho
reviewed
Apr 8, 2022
| @@ -68,7 +68,7 @@ type _ExpandSignature<T> = { | |||
| Blocks: 'Blocks' extends keyof T | |||
| ? { | |||
| [Block in keyof T['Blocks']]: T['Blocks'][Block] extends unknown[] | |||
| ? { Positional: T['Blocks'][Block] } | |||
| ? { Params: { Positional: T['Blocks'][Block] } } | |||
There was a problem hiding this comment.
Thanks for fixing this (and my bad for missing it)!
This was referenced Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two hazards currently facing consumers of the mostly-private
ExpandSignaturetype that landed in #385.Paramswrapper around the fully-expanded form of a block definition, which is missing here when the user provides the shorthand@glimmer/componentpublish their types in different locations (alone indist/types/...in v1, but alongside the implementation indist/{modules,commonjs}/...in v2)This PR adds the missing
{ Params: ... }wrapper and atypesVersionsentry that will allow for a standardized import path between v1 and v2 for privileged consumers of theExpandSignaturetype.I'll also plan to open an equivalent PR to this one against the
v1.xbranch, assuming everything looks ok here./cc @chriskrycho