Fix enabling/disabling collapsed toots, as well as the unfold thread feature #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eceiveProps As we are already using the new getSnapshotBeforeUpdate lifecycle method, we apparently cannot use the deprecated ones at all in this component.
ClearlyClaire
force-pushed
the
glitch-soc/features/unfold-thread
branch
from
2ab7536
to
0ce0665
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both the unfold thread feature (issue #446) and the enabling/disabling of collapsed toots are currently broken because the
Statuscomponent is using both deprecated (componentWillReceiveProps) and newly-introduced (getSnapshotBeforeUpdate, since React 16.3) lifecycle methods. While this is poorly documented, this results in the deprecated methods being ignored.This pull requests ports the functionality of the deprecated method
componentWillReceivePropsusing the newly-introducedgetDerivedStateFromProps.An update of some dependencies was required for the aforementioned method to work properly (see reduxjs/react-redux#879 and reduxjs/react-redux#915).