add createKey method

[macbookandrew]

No description provided.

[mhetreramesh]

Hi @macbookandrew,

Can you describe your change for better understanding?

[macbookandrew]

Sure—sorry, I should have included that to start with. There are two changes in this PR:

1. Add a createKey method to create Application Keys
   • Should I add some tests for this?
2. Add more detail to the bucket API calls so consuming code can determine whether the bucket is S3-compatible and get other bucket options

[ersin-comet]

Hello @mhetreramesh @macbookandrew

This is useful for my current work, thanks for taking the time to work on this!

I have been able to integrate and use this new method, but noticed there is a minor issue with the Key class.

When I call $client->create_key($options) I expect that the created key instance has the correct value returned for getName() and getSecret() methods, however it appears that these keys are swapped around.

What can I do to get this merged upstream?

[macbookandrew]

@ersin-comet Thanks.

however it appears that these keys are swapped around.

You’re right…fixed in 6edc18c

I also added listKeys() and deleteKey() methods.

[macbookandrew]

@mlambley Just curious—did I miss something you wanted in order to merge this? Or would you prefer to keep application keys management out of this package?

[mlambley]

@macbookandrew I didn't mean to close this PR sorry. You will have to recreate it.

[mlambley]

@macbookandrew Then tag me in the new PR and I'll review it.