-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 8 support #58
PHP 8 support #58
Conversation
@mhetreramesh Otherwise your library is perfectly compatible with PHP 8, I'm using it right now. I would love if I could just use your repo instead of my fork, though. Could you please merge & release? Thank you! |
Is this project dead? 💀 |
Hi Ben, I'll be merging this shortly, I just need to sort out a few things with the repo owner. Thanks! |
Thank you @mlambley, looking forward to a PHP 8 compatible release! |
Sorry Ben could you please squash these into a single commit for me? |
@mlambley Done! |
All done. Thank you! |
Thank you, looking forward to a release! |
Thanks, is there a changelog we can see? The Also, please note that because you're just tagging a release and not using the GitHub releases page, the homepage for this project still shows version 1.2.1 as the latest version! |
Honestly I'm not sure, I only started maintaining this project a few weeks ago and I've only ever pushed tags in my own projects. I'll have a look into your suggestions. |
The current
composer.json
is not compatible with PHP 8.I added tests for PHP 8 on Travis, + missing supported PHP versions, 7.3 & 7.4.