Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8 support #58

Merged
merged 1 commit into from
Feb 3, 2021
Merged

PHP 8 support #58

merged 1 commit into from
Feb 3, 2021

Conversation

BenMorel
Copy link
Contributor

@BenMorel BenMorel commented Dec 4, 2020

The current composer.json is not compatible with PHP 8.

I added tests for PHP 8 on Travis, + missing supported PHP versions, 7.3 & 7.4.

@BenMorel
Copy link
Contributor Author

BenMorel commented Dec 9, 2020

@mhetreramesh Otherwise your library is perfectly compatible with PHP 8, I'm using it right now. I would love if I could just use your repo instead of my fork, though. Could you please merge & release? Thank you!

@BenMorel
Copy link
Contributor Author

Is this project dead? 💀

@mlambley
Copy link
Member

Hi Ben, I'll be merging this shortly, I just need to sort out a few things with the repo owner. Thanks!

@BenMorel
Copy link
Contributor Author

Thank you @mlambley, looking forward to a PHP 8 compatible release!

@mlambley
Copy link
Member

Sorry Ben could you please squash these into a single commit for me?

@BenMorel
Copy link
Contributor Author

@mlambley Done!

@mlambley mlambley merged commit 460a551 into gliterd:master Feb 3, 2021
@mlambley
Copy link
Member

mlambley commented Feb 3, 2021

All done. Thank you!

@BenMorel
Copy link
Contributor Author

BenMorel commented Feb 3, 2021

Thank you, looking forward to a release!

@mlambley
Copy link
Member

mlambley commented Feb 3, 2021

https://github.com/gliterd/backblaze-b2/releases/tag/1.5.0

@BenMorel
Copy link
Contributor Author

BenMorel commented Feb 3, 2021

Thanks, is there a changelog we can see? The CHANGELOG file is empty, and so are the release notes for this tag.

Also, please note that because you're just tagging a release and not using the GitHub releases page, the homepage for this project still shows version 1.2.1 as the latest version!

@mlambley
Copy link
Member

mlambley commented Feb 3, 2021

Honestly I'm not sure, I only started maintaining this project a few weeks ago and I've only ever pushed tags in my own projects. I'll have a look into your suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants