Implement sample weight #324
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also log a warning if GLM.fit() doesn't converge
messages now identify the params that caused assertions to fail some assertions are only expected to pass for reg_lambda=0.0 where the true model can be reconstructed almost perfectly Needed to increase the required loss trace improvement threshold from 1e-7 to 1e-3 to deal with occasional noise in cdfast steps
beta is updated by GLM._prox, which invalidates the cached z
the only place that uses _cdfast immediately invalidates the cache
to match package style Disabled flake8 checks: W504 conflicts with W503-type style used in the package W605 conflicts with latex code in Sphinx docstrings
ensure _logL calls use z argument by name
use scipy.special.comb instead of removed scipy.misc.comb
|
Feel free to pull in anything useful! Do it soon, though - I’m leaving 605 shortly and my peterfoley605 account and that fork may disappear. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@peterfoley do you mind if we borrow code from your fork for
pyglmnet? :-)Probably won't get merged soon but I wanted to open a PR so that it's on our radar.