Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add {culture} support for BingMapsLayer #50

Closed
mannodermaus opened this issue Feb 12, 2014 · 3 comments
Closed

Add {culture} support for BingMapsLayer #50

mannodermaus opened this issue Feb 12, 2014 · 3 comments

Comments

@mannodermaus
Copy link

Hey guys,

when trying to implement localized maps for different languages using a BingMapsLayer, I came across the possibility to add the {culture} parameter to the layer's tile petitions, which in turn results in map tiles for different languages. However, the culture parameter has been hardcoded to the default value, "en-US":

BingMapsLayer.java:createTileMapPetitions(G3MRenderContext rc, LayerTilesRenderParameters layerTilesRenderParameters, Tile tile) {
    …
    path = su.replaceSubstring(path, "{subdomain}", subdomain);
    path = su.replaceSubstring(path, "{quadkey}", quadkey);
    path = su.replaceSubstring(path, "{culture}", "en-US");
    …
}

Do you plan to allow other values for BingMapsLayer's culture parameter being passed in to this call in the future?

Thanks in advance! Best regards,
Marcel

@DiegoGomezDeck
Copy link
Member

Hello Marcel,

Thank you very much for your proposal.

I just push a newest version of BingMapsLayer, with an overloaded constructor to specify a "culture" different than the default.

Please test it.

-- Diego

@DiegoGomezDeck
Copy link
Member

a "culture" different than the default.

It didn't sound polite at all, my fault. =o)

@mannodermaus
Copy link
Author

Haha, you got it. ;) It works perfectly, thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants