Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Add config for browserstack-runner #367

Merged
merged 1 commit into from
Jan 12, 2015
Merged

Conversation

jzaefferer
Copy link
Contributor

This is a work in progress, to debug the issues we're still having with this setup.

@jzaefferer
Copy link
Contributor Author

Updated to include both unit and functional tests and a separate config for IE8. Can run the latter with:

BROWSERSTACK_JSON=browserstack-ie8.json browserstack-runner

Both ran successfully on my local machine. I'm still working on the Travis integration.

@@ -0,0 +1,7 @@
{
"test_framework": "qunit",
"test_path": ["test/unit-es5-shim.html", "test/functional-es5-shim.html"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space [ "test/unit-es5-shim.html", "test/functional-es5-shim.html" ]?

@jzaefferer
Copy link
Contributor Author

Btw. since the Travis integration is still problematic, we can start by only landing the config files, so that we can use them locally. We can land the other changes later.

@rxaviers
Copy link
Member

Sounds good to me. Do you want to update this branch accordingly and potentially creating a new PR to track Travis integration?

@rxaviers
Copy link
Member

Can run the latter with:
BROWSERSTACK_JSON=browserstack-ie8.json browserstack-runner

This is really cool!

Uses a separate config file for IE8:

BROWSERSTACK_JSON=browserstack-ie8.json browserstack-runner

Ref #235
@jzaefferer jzaefferer merged commit 3ba23be into master Jan 12, 2015
@jzaefferer jzaefferer deleted the browserstack-runner branch January 12, 2015 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants