-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: Add config for browserstack-runner #367
Conversation
0d08b40
to
ccb8c55
Compare
Updated to include both unit and functional tests and a separate config for IE8. Can run the latter with: BROWSERSTACK_JSON=browserstack-ie8.json browserstack-runner Both ran successfully on my local machine. I'm still working on the Travis integration. |
@@ -0,0 +1,7 @@ | |||
{ | |||
"test_framework": "qunit", | |||
"test_path": ["test/unit-es5-shim.html", "test/functional-es5-shim.html"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Space [ "test/unit-es5-shim.html", "test/functional-es5-shim.html" ]
?
5d2b8dd
to
a19e521
Compare
Btw. since the Travis integration is still problematic, we can start by only landing the config files, so that we can use them locally. We can land the other changes later. |
Sounds good to me. Do you want to update this branch accordingly and potentially creating a new PR to track Travis integration? |
a19e521
to
9ac1b58
Compare
This is really cool! |
9ac1b58
to
082b387
Compare
Uses a separate config file for IE8: BROWSERSTACK_JSON=browserstack-ie8.json browserstack-runner Ref #235
082b387
to
3ba23be
Compare
This is a work in progress, to debug the issues we're still having with this setup.