-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test: Use Sinon.js instead of FakeDate #383
Conversation
Have you verified that sinon and its dependencies use AMD properly? |
I had and it said it would. |
Is there a ticket for getting that tag-free commit tagged properly? |
I've noticed it's tagged as 1.1.10 in the repo. But, as 1.1.0 in npm. |
Looks like the latest version, 1.2.1, is tagged and published, can you use that? |
Can we? Good question. Sinon.js latest release is 1.12.2, which uses lolex@1.1.0 (i.e., 1.1.10 or 3664eb). I would use lolex@1.2.1 when there's a newer Sinon.js release explicitly telling us to use it. |
cc @cjohansen |
Seems easy enough to test. |
Feel free to use Lolex 1.2.1. Sinon master is using it with no problems. |
Thanks |
Closing. Anyone, feel free to continue my work. |
Note: lolex's 3664eb8d90dd1d6fa04a098f77b77b19a6bb5850 sha corresponds
to its 1.1.0 npm version (version is present on npm, but not git tagged
accordingly).
Ref #374
Fixes #382