fix empty editorState sidebar jump #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Nvveen, I've tested your patch and the sidebar does not return to the start position. An alternative approach to fix this problem could be to set the initial top state to -4. (I don't know if this is the best fix).
|
|
Hey @Nvveen, I'm closing this PR ok? Feel free to reopen if you want to give it another try. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As soon as you click on an empty page, the calculation for the top margin for the sidemenu is done, but it comes out as -4, as there are no elements to count. This means the sidebar jumps, but not allowing the top margin to go below 0 fixes this.