Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update A1 - Copy-n-Paste README #165

Merged
merged 69 commits into from
May 21, 2019
Merged

Update A1 - Copy-n-Paste README #165

merged 69 commits into from
May 21, 2019

Conversation

rafaveira3
Copy link
Contributor

This PR is a draft to solve #163 .

@rafaveira3 rafaveira3 added the docs 📖 Add or update documentation label Feb 10, 2019
@rafaveira3
Copy link
Contributor Author

rafaveira3 commented Feb 10, 2019

@rafaeleyng, @vitoriario and @Krlier , would you mind reviewing this one, please? I am setting this as WIP so we can work on this together!


<img src="images/CopyNPaste.png" align="center"/>
<img src="../../../images/secDevLabs-logo.png" align="" height="80" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this first image should be about the app! Not necessarily the app's home page, but maybe it's logo? It would be cool if we could add visual identity to each one of our apps, just like Hack The Box does with it's boxes. What do you guys think @vitoriario , @rafaeleyng ?

It doesn't need to be anything fancy, hack the box has a template and just changes some details to each box to kind of fit the theme. Here's an example:

image

OR

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Krlier, we could use our logo. Something like:

captura de tela 2019-02-11 as 10 28 45

What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using logos is a good idea, however it may take us some time to build "cool" logos for each app. I may need some help doing so! 😃

Also, we have to be careful when using "Difficult: Hard". How will we define what is Hard or what is Easy? Taking vulnhub.com apps as examples, I always had some trouble working on "Beginners" machines and went pretty well on "Medium/Hard" ones. The challenge may be easy for the author but not to whom does it.

@vitoriario
Copy link
Contributor

Hi guys, I think we could move all attack pictures from docs to images folder. What do you think?

@rafaveira3
Copy link
Contributor Author

@vitoriario , thanks for this new commit! 👏🏻 However, Objectives index is not working!

Copy link

@rafaeleyng rafaeleyng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me. I think the logo would add some complexity in creating new apps.
I'm still missing a topic that states clearly the expected results after mitigation.

@rafaveira3 rafaveira3 changed the title WIP: Add attack into README WIP: [A1 - CopyNPaste] Add attack into README Feb 13, 2019
@Krlier Krlier changed the title WIP: [A1 - CopyNPaste] Add attack into README Update A1 - Copy-n-Paste README May 14, 2019
@Krlier Krlier requested a review from spimpaov May 15, 2019 13:27
@Krlier Krlier merged commit 1b197c4 into master May 21, 2019
@rafaveira3 rafaveira3 deleted the change-a1-docs branch May 21, 2019 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants