Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test to ensure AttributeError is raised when frame attributes are None #48

Closed
lyrivera opened this issue May 15, 2019 · 1 comment
Closed

Add unit test to ensure AttributeError is raised when frame attributes are None #48

lyrivera opened this issue May 15, 2019 · 1 comment
Assignees
@klywang
Labels
unittest Unit test required
Milestone
Finish unit tests...

Comments

@lyrivera
Copy link
Contributor

Following the discussion on #39, unit test are required to ensure AttributeError is properly raised when expected. I have already implemented, in the frame-default-fix branch, some of these unit tests for trajectories read from dcd and pos files, but these need to be thoroughly checked. Unit tests are still missing for the other supported file formats.
@lyrivera lyrivera added the unittest Unit test required label May 15, 2019
@klywang klywang mentioned this issue May 16, 2019
Merged
@lyrivera lyrivera mentioned this issue Jun 5, 2019
Merged
@lyrivera
Copy link
Contributor Author

Also resolved on #68. Closing now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@klywang klywang

Labels
unittest Unit test required
Projects
None yet
Milestone
Finish unit tests and debugging major...
Development

No branches or pull requests
2 participants
@klywang @lyrivera