Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The signac shell interpreter should keep a command history #134

Closed
csadorf opened this issue Feb 22, 2019 · 1 comment
Closed

The signac shell interpreter should keep a command history #134

csadorf opened this issue Feb 22, 2019 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
v1.2.0

Comments

@csadorf
Copy link
Contributor

csadorf commented Feb 22, 2019

Feature description

The signac shell interpreter should pertain a command history on a per-project basis.
Invoking signac shell should therefore auto-complete commands based on previous sessions in the same project.

Proposed solution

We are already using the readline module to setup auto-completion, I think it's just a matter of saving the command history as described here.
@csadorf csadorf added enhancement New feature or request good first issue Good for newcomers labels Feb 22, 2019
@csadorf csadorf added this to the v1.1.0 milestone Feb 22, 2019
@csadorf csadorf modified the milestones: v1.1.0, v1.2.0 May 19, 2019
csadorf added a commit that referenced this issue May 19, 2019
@csadorf
Keep signac shell command history on a per-project basis.
18f04df 
Resolves issue #134.
@csadorf csadorf mentioned this issue May 19, 2019
Merged
csadorf added a commit that referenced this issue May 21, 2019
@csadorf
Keep signac shell command history on a per-project basis. (#194)
bbf2b74 
* Keep signac shell command history on a per-project basis.

Resolves issue #134.

* Update changelog.

* Fix Py27 incompatibility.

* Readline module not fully implemented for PyPy.
@csadorf
Copy link
Contributor Author

csadorf commented May 22, 2019

Resolved with merge of PR #194 .

@csadorf csadorf closed this as completed May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
v1.2.0
Development

No branches or pull requests
1 participant
@csadorf