Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep signac shell command history on a per-project basis. #194

Merged
merged 4 commits into from
May 21, 2019

Conversation

csadorf
Copy link
Contributor

@csadorf csadorf commented May 19, 2019

Resolves issue #134.

@csadorf csadorf requested a review from a team as a code owner May 19, 2019 22:22
@codecov
Copy link

codecov bot commented May 20, 2019

Codecov Report

Merging #194 into master will decrease coverage by 1.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #194      +/-   ##
==========================================
- Coverage   65.03%   63.99%   -1.05%     
==========================================
  Files          37       37              
  Lines        5546     5555       +9     
==========================================
- Hits         3607     3555      -52     
- Misses       1939     2000      +61
Impacted Files Coverage Δ
signac/__main__.py 0% <0%> (ø) ⬆️
signac/core/json.py 81.57% <0%> (-13.16%) ⬇️
signac/common/errors.py 72.22% <0%> (-11.12%) ⬇️
signac/contrib/job.py 86.11% <0%> (-4.37%) ⬇️
signac/contrib/project.py 89.13% <0%> (-1.49%) ⬇️
signac/contrib/indexing.py 73.77% <0%> (-1.48%) ⬇️
signac/contrib/collection.py 87.59% <0%> (-1.32%) ⬇️
signac/core/jsondict.py 93.86% <0%> (-1.23%) ⬇️
signac/core/dict_manager.py 88.37% <0%> (-1.17%) ⬇️
signac/contrib/filesystems.py 31.13% <0%> (-0.95%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbe589d...be43c19. Read the comment docs.

@codecov
Copy link

codecov bot commented May 20, 2019

Codecov Report

Merging #194 into master will decrease coverage by 0.12%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #194      +/-   ##
=========================================
- Coverage   65.03%   64.9%   -0.13%     
=========================================
  Files          37      37              
  Lines        5546    5557      +11     
=========================================
  Hits         3607    3607              
- Misses       1939    1950      +11
Impacted Files Coverage Δ
signac/__main__.py 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbe589d...b9d2226. Read the comment docs.

@csadorf
Copy link
Contributor Author

csadorf commented May 20, 2019

Not sure why the coverage decreased. Maybe, because I'm skipping the history code segment on PyPy?

@vyasr
Copy link
Contributor

vyasr commented May 21, 2019

It looks like the coverage tracking as a whole doesn't recognize that test_shell.py is actually calling the __main__.py functions, the package must not know how to deal with entry points. The entire __main__.py has 0% coverage. I wouldn't worry about it.

Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. As we add more special signac files, we may want to consider putting them into a .signac directory or something, though.

@csadorf csadorf merged commit bbf2b74 into master May 21, 2019
@csadorf csadorf deleted the feature/keep-shell-history branch May 21, 2019 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants