-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep signac shell command history on a per-project basis. #194
Conversation
Resolves issue #134.
Codecov Report
@@ Coverage Diff @@
## master #194 +/- ##
==========================================
- Coverage 65.03% 63.99% -1.05%
==========================================
Files 37 37
Lines 5546 5555 +9
==========================================
- Hits 3607 3555 -52
- Misses 1939 2000 +61
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #194 +/- ##
=========================================
- Coverage 65.03% 64.9% -0.13%
=========================================
Files 37 37
Lines 5546 5557 +11
=========================================
Hits 3607 3607
- Misses 1939 1950 +11
Continue to review full report at Codecov.
|
Not sure why the coverage decreased. Maybe, because I'm skipping the history code segment on PyPy? |
It looks like the coverage tracking as a whole doesn't recognize that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me. As we add more special signac files, we may want to consider putting them into a .signac directory or something, though.
Resolves issue #134.