Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show() should be optional #35

Closed
eteq opened this issue Sep 18, 2018 · 2 comments
Closed

show() should be optional #35

eteq opened this issue Sep 18, 2018 · 2 comments

Comments

@eteq
Copy link
Collaborator

eteq commented Sep 18, 2018

Continuing in a series of issues that are "confusing elements of the API" from work on #28 :

Right now the visualizations always get shown whenever a glupyter visualization is executed. But there are times when it's useful to create the widget but not show it until it is the last line of a cell. While I can see the merit of either way of doing it, there should be a way to control this so that it's possible to not get the show() on create beahvior

@astrofrog
Copy link
Member

@eteq - it's now possible to set show=False when creating a viewer:

https://github.com/glue-viz/glue-jupyter/blob/master/glue_jupyter/app.py#L184

The default is still True though. Are you ok with that?

@astrofrog
Copy link
Member

I'll go ahead and close this since I think this has been addressed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants