Preserve rotation angle under dragging for ellipse and rectangle selection tools

[pllim]

In Jdaviz, you can rotate ellipse and rectangle ROIs using Subset Tools plugin. After that is done, and user wants to click and drag the shape, without this patch, the rotation resets. This patch preserves any existing rotation. Since I really don't want to implement theta support in JS (e.g., https://github.com/glue-viz/bqplot-image-gl/blob/main/js/lib/BrushEllipseSelector.js), during the dragging phase, the gray shape has no rotation, but the rotation comes back when you finalize the drag.

cc @astrofrog and @dhomeier

🐱

[codecov]

Codecov Report

Patch coverage: 71.42% and project coverage change: -0.50% ⚠️

Comparison is base (c98cb9d) 87.33% compared to head (4f62514) 86.84%.
Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #396      +/-   ##
==========================================
- Coverage   87.33%   86.84%   -0.50%     
==========================================
  Files          89       89              
  Lines        5013     5076      +63     
==========================================
+ Hits         4378     4408      +30     
- Misses        635      668      +33     

Files Changed	Coverage Δ
glue_jupyter/bqplot/common/tools.py	66.80% <71.42%> (-3.34%)	⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dhomeier]

Too bad again that moving cannot be tested currently, but otherwise this looks good – as mentioned, I am unable to check if this works for Rectangle, but for Ellipse it does as expected, so I'll trust that the former is solved for you as well.

[pllim]

Try test it over in Imviz. Install this branch, and then install Jdaviz, and test it there.

[dhomeier]

Try test it over in Imviz. Install this branch, and then install Jdaviz, and test it there.

That's what I did, or do you mean installing in different order makes any difference?
Seems totally non-deterministic anyway – at first moving did not update properly in the regular notebook, but worked in Jupyterlab; now it's functioning normally in the standard notebook, but there is no way to access roi.rotate_by, while in Imviz the rectangles (and only rectangles) can't be moved at all...

[pllim]

I think as long as you can prove to yourself using ellipse, it is good enough? The logic is the same in both. If you want to, we can meet at some point and I can screenshare, but not today.

[dhomeier]

OK, I could confirm it in the standalone app, and then after relaunching everything, moving worked in the notebook as well!

[pllim]

I created an issue upstream for the confusing "shadow." FYI. glue-viz/bqplot-image-gl#106