compatibility mode #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needs more testing, and there are some unanswered questions
glujan
requested changes
Nov 8, 2023
There was a problem hiding this comment.
Could you please pull the newest master into your branch, install pre-commit with pip (pip install pre-commit) in your venv and run pre-commit run --all-files and commit any changes made by the tool?
Other than that I have just 1 small change request in tests.
Thank you for this PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #43 by adding a new command line option
--compatibility-mode. When this flag is used,drpgattempts to emulate the file/directory naming algorithm that the DriveThruRPG client app uses, including its bugs and idiosyncrasies. See the discussion for more details.