Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the packages required for a Debian/Ubuntu machine #56

Closed
wants to merge 1 commit into from

Conversation

Sheetalpamecha
Copy link
Member

To automate building and packaging of packages a
builder with following specifications is required

see #1727727
Signed-off-by: Sheetal Pamecha spamecha@redhat.com

To automate building and packaging of packages a
builder with following specifications is required

see #1727727
Signed-off-by: Sheetal Pamecha <spamecha@redhat.com>
Copy link
Contributor

@mscherer mscherer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ho, sorry to be late on doing the review, i missed it.

@@ -145,6 +145,20 @@
# requested on https://bugzilla.redhat.com/show_bug.cgi?id=1609347
- argp-standalone

- name: Add Packages specific to debian/ubuntu builders
packages:
state: absent
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should the package be absent ?

- dpkg-sig #To create and verify signature
- debootstrap #To install debian base system
- chrpath #to modify the dynamic library load path
when: '"jenkins_builders_rht" in group_names and ansible_distribution == "Debian/Ubuntu"'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ansible_distribution match is unlikely to work, it should likely be when: ansible_distribution == 'Debian' or ansible_distribution == 'Ubuntu' .

Also, we have a role dedicated to that, see debian_package_builder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants