errno is set to EINVAL on successful writes #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prashanth Pai <ppai@redhat.com>
|
Snippet to reproduce the bug: https://gist.github.com/prashanthpai/c89f096698faf89490cb |
| // FIXME: errno is set to EINVAL even though write is successful. This | ||
| // is probably a bug. Remove this workaround when that gets fixed. | ||
| err = nil | ||
| } |
There was a problem hiding this comment.
Is this a bug with gfapi itself? If there is a bug-id associated with this for gfapi, please mention it.
There was a problem hiding this comment.
Haven't looked into it yet but made a note of it and plan to do it later. I'm certain that the bug is not in the go bindings. The behavior is easily observable: https://gist.github.com/prashanthpai/c89f096698faf89490cb
This also results in ret being 0, errno set to |
|
I opened an issue #14 to track the workaround. I'll merge this now. Thanks. |
kshlm
added a commit
that referenced
this pull request
Dec 7, 2015
errno is set to EINVAL on successful writes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Prashanth Pai ppai@redhat.com