Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added JSX formatting to JavaScript #19

Closed
wants to merge 1 commit into from

Conversation

lukkea
Copy link

@lukkea lukkea commented Feb 21, 2020

Description

This comment by @hbergren prompted me to pull this repo into syntax-highlighting. With a couple of tweeks it's working. I have added a "JSX" option to the menu. I also wondered if there should also be a "React" option that does the same as this, but that seemed unnecessary to me so I didn't do that.

I didn't follow the contributing guidelines in my previous pull request and just realised I hadn't created a dedicated branch to hold the changes (I just used a repo I wasn't going to use for anything else).

I have now done it as Glutanimate requested.

Checklist:

Please replace the space inside the brackets with an x and fill out the ellipses if the following items apply:

  • I've read and understood the contribution guidelines
  • I've tested my changes against at least one of the following Anki builds:
    • Latest standard Anki 2.1 binary build [required for Anki-compatible 2.1 add-ons]
    • [] Latest alternative Anki 2.1 binary build
    • Latest Anki 2.0 binary build [required for Anki 2.0-compatible add-ons]
  • I've tested my changes on at least one of the following platforms:
    • Linux, version:
    • Windows, version:
    • macOS, version:
  • My changes potentially affect non-desktop platforms, of which I've tested:
    • AnkiMobile, version:
    • AnkiDroid, version:
    • AnkiWeb

@lukkea lukkea mentioned this pull request Feb 25, 2020
3 tasks
@Digital-Coder
Copy link

it is unfortunate that they didnt merge this pull request and I was lucky to find it here because I really need JSX support. Thanks a lot @lukkea !

@danielvelara
Copy link

Hi @lukkea, is there a way we could also create a PR for adding TSX support?

@lukkea
Copy link
Author

lukkea commented Sep 19, 2021

Hi @lukkea, is there a way we could also create a PR for adding TSX support?

Yes - tsx could be added the list, but this PR is around eighteen months old and, along with a couple of others I did in @glutanimate's repos, it doesn't appear to have been seen by any maintainers so I expect it might not be the best way you could spend an hour or so...

@lukkea lukkea closed this Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants