Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO-468: Benchmark CI hardware & print extra info #811

Merged
merged 3 commits into from
Jan 10, 2023

Conversation

atodorov
Copy link
Contributor

Description of proposed changes:

Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@github-actions
Copy link

For full LLVM coverage report click here!

@atodorov atodorov changed the title Benchmark reference hardware DO-468: Benchmark reference hardware Dec 12, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #811 (fc4782f) into testnet (54e9f6c) will decrease coverage by 1.72%.
The diff coverage is 69.98%.

@@             Coverage Diff             @@
##           testnet     #811      +/-   ##
===========================================
- Coverage    79.97%   78.24%   -1.73%     
===========================================
  Files           50       51       +1     
  Lines        10056    10317     +261     
===========================================
+ Hits          8042     8073      +31     
- Misses        2014     2244     +230     
Impacted Files Coverage Δ
node/src/benchmarking.rs 0.00% <0.00%> (ø)
node/src/chain_spec.rs 0.00% <0.00%> (ø)
node/src/cli.rs 34.54% <0.00%> (ø)
node/src/command.rs 0.00% <0.00%> (ø)
node/src/main.rs 16.66% <ø> (ø)
node/src/rpc.rs 0.00% <0.00%> (ø)
node/src/service.rs 0.00% <0.00%> (ø)
node/src/service/nonce_monitor.rs 0.00% <0.00%> (ø)
pallets/creditcoin/runtime-api/src/lib.rs 42.85% <ø> (+6.49%) ⬆️
pallets/creditcoin/src/migrations/mod.rs 0.00% <0.00%> (ø)
... and 45 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@atodorov atodorov force-pushed the benchmark-reference-hardware branch from 9be0899 to c2bff67 Compare January 5, 2023 15:55
otherwise automatically generated weights from benchmarks may not be
representative
and don't fail b/c none of our runners meet hardware requirements now
@atodorov atodorov changed the base branch from testnet to dev January 5, 2023 17:38
@atodorov atodorov force-pushed the benchmark-reference-hardware branch from c2bff67 to 5de484b Compare January 5, 2023 17:38
@atodorov atodorov marked this pull request as ready for review January 5, 2023 17:39
@atodorov atodorov changed the title DO-468: Benchmark reference hardware DO-468: Benchmark CI hardware & print extra info Jan 5, 2023
@atodorov atodorov enabled auto-merge (rebase) January 10, 2023 08:11
@atodorov atodorov merged commit 7f6f075 into dev Jan 10, 2023
@atodorov atodorov deleted the benchmark-reference-hardware branch January 10, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants