CSUB-387: Fix pallet discovery script #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For full LLVM coverage report click here! |
atodorov
force-pushed
the
CSUB-387-fix-pallet-discovery-script
branch
from
0819858
to
b449e1f
Compare
Codecov Report
@@ Coverage Diff @@
## dev #883 +/- ##
=======================================
Coverage 78.24% 78.24%
=======================================
Files 68 68
Lines 10726 10726
=======================================
Hits 8393 8393
Misses 2333 2333 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
atodorov
force-pushed
the
CSUB-387-fix-pallet-discovery-script
branch
from
b449e1f
to
4544156
Compare
inside ci.yml we need to compare the list of pallets for which dummy weights are being generated in the test job. This list comes from ci.yml not from bench.yml!
this is the canonical list of pallets which we should compare against everywhere else! NOTE: only pallets which implement extrinsics are discovered by this script. Pallets which don't expose extrinsics are ignored!
b/c it introduces new locations and the search needs to be more flexible
atodorov
force-pushed
the
CSUB-387-fix-pallet-discovery-script
branch
from
4544156
to
0eff8ca
Compare
CAGS295
suggested changes
Jan 13, 2023
sometimes downloading latest release fails and I want to know what exactly happened when there is a failure
atodorov
force-pushed
the
CSUB-387-fix-pallet-discovery-script
branch
from
01d1902
to
1528a7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes:
Practical tips for PR review & merge: