CSUB-1102: Refactoring around docker files #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atodorov
commented
Jun 25, 2024
•
atodorov
commented
- enable build jobs on PRs & conditionally push to Docker Hub
- use a single Dockerfile with arguments instead of multiple to minimize the possibility for divergence between them
- Drop duplication inside release pipeline and replace by matrix job
|
For full LLVM coverage report click here! |
atodorov
force-pushed
the
refactor/CSUB-1102-use-single-dockerfile
branch
2 times, most recently
from
4cd452a
to
1f7928f
Compare
only push the resulting docker images if the CI job was not triggered on a pull request (e.g. push to a release branch or manually triggered)
remove the duplicate files and use a build argument for the different images
otherwise we get a warning: LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 33) Dockerfile:30
b/c it leads to errors: useradd: UID 1000 is not unique
atodorov
force-pushed
the
refactor/CSUB-1102-use-single-dockerfile
branch
from
1f7928f
to
62a774f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.