accept outputs with fewer arguments than their inputs per issue #29 #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some artificial restrictions that this implementation imposes for the sake of simplicity. - outputs may accept *args if and only if the input accepts *args - outputs may accept **kwargs if and only if the input accepts **kwargs - If a py3 type annotation is present on an argument in an output's signature then the same argument and type annotation must appear in the input's signature.
fmoor
force-pushed
the
feature/output_args
branch
from
1e41a13
to
d5d5acc
Compare
fmoor
force-pushed
the
feature/output_args
branch
from
d5d5acc
to
40905d4
Compare
|
I don't really have time for reviews right now but I'd love it if someone else could review this and land it. @markrwilliams @warner do I need to give either of you push rights to the repo? |
|
Looking at this now, it looks OK. I have minor nitpicks (I'd rather attr than namedtuple, docs should be updated) but this is an improvement and it doesn't expose any unrelated public API, so I can always fix it up later :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some artificial restrictions that this implementation imposes
for the sake of simplicity.
then the same argument and type annotation must appear
in the input's signature.