Preserve hostnames in the SRV tuple #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the SRV records refer to TLS-protected services, always knowing the name of the service (as present in the SRV RR) is important so as to properly verify the connection. This commit modifies the tuple structure to add a hostname field (in addition to the host field) which contains the original hostname from the RR. Where the name to IP mapping fails (perhaps because the name isn't resolvable), the SRV tuple will contain the same value in both the host and hostname fields). The hostname field is added to the end of the tuple to minimise backward compatibility issues.
|
+1, please merge and push this |
|
Foolishly I didn't check the tests. I will take a look at getting them to pass tonight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the SRV records refer to TLS-protected services, always knowing
the name of the service (as present in the SRV RR) is important so as to
properly verify the connection.
This commit modifies the tuple structure to add a hostname field (in
addition to the host field) which contains the original hostname from
the RR.
Where the name to IP mapping fails (perhaps because the name isn't
resolvable), the SRV tuple will contain the same value in both the host
and hostname fields).
The hostname field is added to the end of the tuple to minimise backward
compatibility issues.
Fixes #4