Correct type specifications of parse/1,2 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type specification says the functions cannot err, though the code clearly shows that as a possible outcome. This means users of the dialyzer will get warnings in their code bases if they rely on the error handling and matches on the error term. Solve this by adding the right kind of type specification to the different parts of the code base.
Codecov Report
@@ Coverage Diff @@
## master #7 +/- ##
=======================================
Coverage 94.18% 94.18%
=======================================
Files 1 1
Lines 86 86
=======================================
Hits 81 81
Misses 5 5
Continue to review full report at Codecov.
|
|
Thanks, I'll push a new release to hex.pm today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type specification says the functions cannot err, though the code
clearly shows that as a possible outcome. This means users of the
dialyzer will get warnings in their code bases if they rely on the
error handling and matches on the error term.
Solve this by adding the right kind of type specification to the
different parts of the code base.