Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support TLS #1

Merged
merged 4 commits into from
May 8, 2024
Merged

feat: support TLS #1

merged 4 commits into from
May 8, 2024

Conversation

leslie-fei
Copy link

Based on the official TLS library for Golang, make modifications.

@panjf2000
Copy link
Member

Thank you for this PR. But you misunderstood what I said before, I meant we should copy the go std TLS library to this repository and make some modifications for gnet, then make gnet import this repository to support TLS.

@leslie-fei
Copy link
Author

leslie-fei commented May 2, 2024

Thank you for this PR. But you misunderstood what I said before, I meant we should copy the go std TLS library to this repository and make some modifications for gnet, then make gnet import this repository to support TLS.

@panjf2000 了解了, 我把无关代码去了, 只保留TLS库的代码, 只留下TLS Server功能, 主要就是把握手部分改成非阻塞 还有就是读取数据包的部分改成非阻塞, 如果数据不足就返回ErrNotEnough错误, 等待下一轮数据到来

@panjf2000 panjf2000 added enhancement New feature or request feature labels May 8, 2024
Copy link
Member

@panjf2000 panjf2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. This LGTM.

@panjf2000 panjf2000 merged commit f3c43f0 into gnet-io:main May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants