Skip to content
This repository has been archived by the owner on Oct 8, 2022. It is now read-only.

Windows compatibility #61

Closed
diorcety opened this issue May 11, 2014 · 3 comments
Closed

Windows compatibility #61

diorcety opened this issue May 11, 2014 · 3 comments
Assignees
@satabin
Labels
bug
Milestone
v1.0.0-M2

Comments

@diorcety
Copy link

Path separator. Actually the unix path separator is hard coded (:) . Should use path.separator system property
timeout command: timeout command on Windows exists but don't work like *nix one.
Maybe a scala side timeout function should be the best way to resolve that
@satabin
Copy link
Member

satabin commented May 11, 2014

Can you please precise at what places you found them?

@satabin satabin added the bug label May 11, 2014
@satabin satabin added this to the v1.0.0-M2 milestone May 11, 2014
@satabin satabin self-assigned this May 11, 2014
@diorcety
Copy link
Author

Path separator
Server.scala:43
Server.scala:54
timeout command:
SystemCommand

satabin added a commit that referenced this issue May 11, 2014
@satabin
Make path separator system dependent
12073d9 
This is part of windows compatibility in #61
satabin added a commit that referenced this issue May 11, 2014
@satabin
Make path separator system dependent
0b5ffd0 
This is part of windows compatibility in #61
satabin added a commit that referenced this issue May 11, 2014
@satabin
Handle process timeout in scala
983091e 
`timeout` command under windows does not do what we expected it to do.
Handling it in scala should make the code much more portable.
This is part of ticket #61.
@satabin
Copy link
Member

satabin commented May 27, 2014

This should be fixed now, please reopen it if problems persist

@satabin satabin closed this as completed May 27, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@satabin satabin

Labels
bug
Projects
None yet
Milestone
v1.0.0-M2
Development

No branches or pull requests
2 participants
@diorcety @satabin