-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tree query compiler implementation #428
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satabin
force-pushed
the
finite-state/queries
branch
from
December 15, 2022 18:28
1214f2c
to
38cf16a
Compare
satabin
force-pushed
the
finite-state/queries
branch
from
December 23, 2022 17:19
ac869a8
to
a6012bb
Compare
satabin
force-pushed
the
finite-state/queries
branch
from
January 6, 2023 18:48
e1c16dc
to
05f21b1
Compare
The type checker really isn't good with covariance and pattern matching.
ybasket
approved these changes
Jan 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, just left some tiny nitpicks. As for the algorithmic soundness, I'll wait for your paper on the topic.
finite-state/shared/src/main/scala/fs2/data/mft/query/QueryCompiler.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The common query language over tree structures, based on the technique described in XQuery Streaming by Forest Transducers.
This will be used to implement compilation of jq and xquery queries.