-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(examples): playground section homepage #1641
chore(examples): playground section homepage #1641
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1641 +/- ##
==========================================
- Coverage 56.57% 56.17% -0.41%
==========================================
Files 439 439
Lines 66618 66242 -376
==========================================
- Hits 37688 37209 -479
- Misses 26013 26143 +130
+ Partials 2917 2890 -27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -143,6 +144,15 @@ func socialLinks() ui.Element { | |||
} | |||
} | |||
|
|||
func playgroundSection() ui.Element { | |||
return ui.Element{ | |||
ui.H3("Gno Playground, a DevX tool to write and deploy smart contracts directly on Gno.land"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's very long.
What about:
### Gno Playground
> a DevX tool to write and deploy smart contracts directly on Gno.land
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title would be easier to read and the page less heavy, so more pleasant to scroll.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@salmad3 any suggestions to make this title shorter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just "Create, deploy, and share smart contracts."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexiscolin can we update it as "Build, Deploy, and Share Smart Contracts with Playground" and resolve this comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which is (visually) better in your opinion?
Build, Deploy, and Share Smart Contracts with Playground
or:
Gno Playground
Build, Deploy, and Share Smart Contracts
This is bikeshedding at this point, so I don't care whatever we do, but I'm personally of the opinion that a header should be to the point and not screw me around with productspeech. Especially since we don't have visual tools to put emphasis on "Playground" in the title.
Whichever is fine, though. So long as the line doesn't literally wrap around.
Hey folks, any blockers for this (aside from updating the header element)? |
@@ -143,6 +144,15 @@ func socialLinks() ui.Element { | |||
} | |||
} | |||
|
|||
func playgroundSection() ui.Element { | |||
return ui.Element{ | |||
ui.H3("Gno Playground, a DevX tool to write and deploy smart contracts directly on Gno.land"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexiscolin can we update it as "Build, Deploy, and Share Smart Contracts with Playground" and resolve this comment?
We're good after fixing that up |
This PR is shadowed by #1741, for the sake of urgency (we don't want to bother @alexiscolin while he is on his OOO :D) |
…ge (#1741) ## Description As the title says, on request by @ilgooz & marketing. Shadows #1641. <details><summary>Contributors' checklist...</summary> - [ ] Added new tests, or not needed, or not feasible - [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [ ] Updated the official documentation or not needed - [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details>
Adding Gno Playground section into gno.land homepage website.