-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(examples): playground section homepage #1641
Closed
alexiscolin
wants to merge
5
commits into
gnolang:master
from
alexiscolin:chore/playground-section-homepage
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e2d8d05
chore: add playground section into gno.land homepage
alexiscolin 8e6865c
fix: tab
alexiscolin 5bec84e
fix: lint
alexiscolin 3248de4
Merge branch 'master' into chore/playground-section-homepage
alexiscolin 3de266f
Merge branch 'master' into chore/playground-section-homepage
alexiscolin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,6 +19,7 @@ func Render(_ string) string { | |
// body | ||
dom.Body.Append(introSection()...) | ||
dom.Body.Append(ui.Jumbotron(worxDAO())) | ||
dom.Body.Append(playgroundSection()...) | ||
dom.Body.Append(packageStaffPicks()...) | ||
dom.Body.Append(ui.HR{}) | ||
dom.Body.Append( | ||
|
@@ -143,6 +144,15 @@ func socialLinks() ui.Element { | |
} | ||
} | ||
|
||
func playgroundSection() ui.Element { | ||
return ui.Element{ | ||
ui.H3("Gno Playground, a DevX tool to write and deploy smart contracts directly on Gno.land"), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @alexiscolin can we update it as "Build, Deploy, and Share Smart Contracts with Playground" and resolve this comment? |
||
ui.Paragraph("Gno Playground is a simple web interface that lets you run, test, and experiment with your Gno code to improve your understanding of the Gnolang language. You can share your code, run unit tests, deploy your realms and packages, and execute functions in your code using the repo."), | ||
ui.Paragraph("Get inspired by testing out the new packages and realms below in Gno Playground."), | ||
ui.Link{Text: "Get started with Gno Playground", URL: "https://play.gno.land/"}, | ||
} | ||
} | ||
|
||
func packageStaffPicks() ui.Element { | ||
// XXX: make it modifiable from a DAO | ||
return ui.Element{ | ||
|
@@ -224,6 +234,7 @@ func discoverLinks() ui.Element { | |
|
||
- [Gno dev with CLI (soon)](#) | ||
- [Explore the Universe](/ecosystem) | ||
- [Gno Playground](https://play.gno.land) | ||
- [Test in the browser (soon)](#) | ||
- [About the Gno Language](/gnolang) | ||
- [Docs/ Tutorials](https://github.com/gnolang) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's very long.
What about:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @ccomben I tend to agree with @thehowl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title would be easier to read and the page less heavy, so more pleasant to scroll.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @michelleellen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@salmad3 any suggestions to make this title shorter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just "Create, deploy, and share smart contracts."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexiscolin can we update it as "Build, Deploy, and Share Smart Contracts with Playground" and resolve this comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which is (visually) better in your opinion?
Build, Deploy, and Share Smart Contracts with Playground
or:
Gno Playground
This is bikeshedding at this point, so I don't care whatever we do, but I'm personally of the opinion that a header should be to the point and not screw me around with productspeech. Especially since we don't have visual tools to put emphasis on "Playground" in the title.
Whichever is fine, though. So long as the line doesn't literally wrap around.