Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update CallRequest with a list of MsgCall #114

Merged
merged 1 commit into from
Feb 9, 2024
Merged

chore: Update CallRequest with a list of MsgCall #114

merged 1 commit into from
Feb 9, 2024

Conversation

jefft0
Copy link
Contributor

@jefft0 jefft0 commented Feb 9, 2024

The gnoclient API method Call was updated to use a list of MsgCall in one transaction. We want Gno Native Kit to closely follow the gnoclient API, so this PR updates the gRPC API:

  • In gnonativetypes.go, add MsgCall and update CallRequest to use it.
  • Run make regenerate .
  • Copy api/gen/es/gnonativetypes_pb.* to gnoboard and hello projects.
  • In api.go, update Call to make the list of gnoclient.MsgCall .
  • In all the copies of "use-gno", update call to make a list of MsgCall

@jefft0
chore: Update CallRequest with a list of MsgCall
09878cc 
Signed-off-by: Jeff Thompson <jeff@thefirst.org>
@jefft0 jefft0 requested a review from D4ryl00 February 9, 2024 11:15
D4ryl00
D4ryl00 approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@D4ryl00 D4ryl00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jefft0 jefft0 merged commit 136e4f9 into gnolang:main Feb 9, 2024
@jefft0 jefft0 deleted the chore/change-Call-to-multi-using-MsgCall branch February 9, 2024 13:47
@jefft0 jefft0 mentioned this pull request Feb 12, 2024
Merged
@michelleellen michelleellen mentioned this pull request Feb 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@D4ryl00 D4ryl00 D4ryl00 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jefft0 @D4ryl00