Test getWrapped1155DeployBytecode dynamic names #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace Wrapped1155 bytecode for adapt dynamic names with diferent length. - Rename `src` to `contract` for truffle compile.
rmeissner
reviewed
Feb 9, 2021
rmeissner
reviewed
Feb 9, 2021
nlordell
reviewed
Feb 10, 2021
There was a problem hiding this comment.
On a side note unrelated to the changes: I'm not super familiar with the project, but I don't quite understand why the deployed bytecode needs to write EVM codes (instead of letting Solidity generate a constructor for example). Is this just a gas optimization?
Otherwise, changes look good.
edit: Ah I see now, its because we are using a minimal proxy implementation for the ERC20 wrapper.
- Rename `tokenNameOffset` to `tokenNameLength`. - Replace `bytes` type to `bytes31` and `uint8` for `tokenName` and `tokenLength`. - Add `Deposit` event. See #4 (comment)
Revert `tokenName` bytes31 to type bytes to be able to slice calldata `data` on override methods `onERC1155Received` and `onERC1155BatchReceived`.
Add dynamic tokenName, symbol, and decimals into the `getWrapped1155DeployBytecode` method as `bytes calldata` `data` parameters to allow use them in `onERC1155Received` and `onERC1155BatchReceived` 1155 methods. This will allow to pass as bytes the encoded bytecode for the `tokenName` and `tokenSymbol` as push bytes32 and `tokenDecimals` as push bytes on the EVM: To call methods with `bytes calldata` parameters it is required to calculate the values on the client using the following steps: - `tokenName`: bytes32, string in hexadecimal and the zero paddings and the length of the string in hexadecimal. eg: for "WrappedERC-1155" is "0x577261707065644552432d31313535000000000000000000000000000000001e". - `tokenSymbol`: bytes32, the string in hexadecimal, zero paddings, and the length of the string in hex. eg: for "WMT" is "0x574d540000000000000000000000000000000000000000000000000000000006". - `tokenDecimal`: bytes, the number in hexadecimal. eg: 18 as 0x12.
Add 1155-to-20-helper repository to generate the bytecode ERC-20 metadas on tests.
- Remove the `abi.decode` receiver addresses and use `operator` as default receiver address on `onERC1155Received` and `onERC1155BatchReceived`. - Remove comments from `getWrapped1155DeployBytecode`.
- Add bytecode especification. - Add More-Minimal Proxy bytecode. - Include references.
- Add token `bytes calldata data` support on batch methods `onERC1155BatchReceived` and `batchUnwrap` with requirement of data.length should be module of 65 with the same size of `ids` and `tokenIds` arrays. - Add SafeMath for add, mul, and div operators. - Add @openzeppelin/contracts `v3.4.0` dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
srctocontractfor truffle compile.Resolves #3