Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

WIP - Orders panel part 2 (Open ordersPanel on click connect wallet) #1203

Merged
merged 1 commit into from
Aug 13, 2021

Conversation

fairlighteth
Copy link
Contributor

Summary

This implements functionality to open the orders panel, when you click on your connected wallet.

To Test

  1. Connect a wallet
  2. Click on your wallet after being connected.
  3. Should open the orders panel.
  4. That's it.

@fairlighteth fairlighteth requested review from anxolin, W3stside and alfetopito and removed request for anxolin August 9, 2021 09:57
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2021

  • 🔭 GP Swap: Gnosis Protocol v2 Swap UI

Copy link
Contributor

@W3stside W3stside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

niiiice way way way easier to review. thanks

Copy link
Contributor

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working like a charm

Minor: you could in this PR remove the button on top since it's no longer needed
screenshot_2021-08-09_10-02-56

@fairlighteth fairlighteth merged commit 5dd110f into orders-panel-1 Aug 13, 2021
@alfetopito alfetopito deleted the orders-panel-2 branch August 13, 2021 16:40
nenadV91 pushed a commit that referenced this pull request Aug 27, 2021
* Orders panel component.

* Props update.

* Open ordersPanel on click connected wallet. (#1203)

* WIP - Orders panel part 3 (Add wallet + orders to the sidebar) (#1210)

* Open ordersPanel on click connected wallet.

* Orders in side bar WIP.

* Fix issue types

* Revert "Fix issue types"

This reverts commit cb95c89.

* Fix issue with types 2

* Account details inside orders sidebar.

* Fix import.

* Fix folder name.

Co-authored-by: Anxo Rodriguez <anxolin@gmail.com>

* WIP - Orders panel part 4 (Re-style account details/activity/orders) (#1227)

* Open ordersPanel on click connected wallet.

* Orders in side bar WIP.

* Fix issue types

* Revert "Fix issue types"

This reverts commit cb95c89.

* Fix issue with types 2

* Account details inside orders sidebar.

* Fix import.

* Fix folder name.

* Re-style of account details/activity.

Co-authored-by: Anxo Rodriguez <anxolin@gmail.com>

* WIP - Orders panel part 5 (More styling and tweaking) (#1234)

* Open ordersPanel on click connected wallet.

* Orders in side bar WIP.

* Fix issue types

* Revert "Fix issue types"

This reverts commit cb95c89.

* Fix issue with types 2

* Account details inside orders sidebar.

* Fix import.

* Fix folder name.

* Re-style of account details/activity.

* Orders sidebar styling.

* Orders sidebar styling.

* Orders sidebar styling.

* Orders sidebar styling.

* Orders sidebar styling.

* Transaction update.

* Transaction update.

Co-authored-by: Anxo Rodriguez <anxolin@gmail.com>

* WIP - Orders panel part 6 (Address feedback an wallet issues) (#1249)

* Open ordersPanel on click connected wallet.

* Orders in side bar WIP.

* Fix issue types

* Revert "Fix issue types"

This reverts commit cb95c89.

* Fix issue with types 2

* Account details inside orders sidebar.

* Fix import.

* Fix folder name.

* Re-style of account details/activity.

* Orders sidebar styling.

* Orders sidebar styling.

* Orders sidebar styling.

* Orders sidebar styling.

* Orders sidebar styling.

* Transaction update.

* Transaction update.

* Fix wallet stuff.

* Fix wallet stuff.

* Mobile tx detail indent.

* WIP - Orders panel part 7 (TBD) (#1250)

* tablet size fix

* Fix 1238

Co-authored-by: Anxo Rodriguez <anxolin@gmail.com>

* Rename prop.

* Orders Sidebar --> Slide in effect. (#1270)

* Sidebar slide in.

* Scroll fix.

* Orders Sidebar --> Click to copy move. (#1269)

* Click to copy move.

* Icon wrapper remove.

* Mobile header fixes.

* Re-factor Copy component.

* Cancelling label re-factor + Fix cancellation modal (#1293)

* Cancelling label re-factor.

* Fix close modal/sidebar click event.

* Shimmer effect OPEN orders.

* closeOrdersPanel for FAQ link.

* Refert passing prop, instead open link new tab.

* Update src/custom/components/AccountDetails/Transaction.tsx

Co-authored-by: David <david.sato64@gmail.com>

Co-authored-by: David <david.sato64@gmail.com>

* Orders Sidebar --> Show limit prices + valid to/filled on dates (#1279)

* Add limit price and valid to/filled date.

* Add limit price and valid to/filled date.

* Fixed type of getLimitPrice utils function

* Execution price WIP.

* Styled file for cleanup.

* Styled file for cleanup.

* Fix grid on mobile (Safari).

* comment out getExecutedPrice

* Expired order strike through.

* Unfillable faq link external.

* Price functions for Recent History (#1289)

* Add bignumber, so library matches our dex-js

* Add price utils

* Refactor transaction summary

* Change todo

* Rename variable to executionPrice.

* Delete comment

* Remove comments and improve doc

* Fix path and default value

* Add datatype for api additional data (#1290)

# Summary

Continues #1289, 

Augment the order datatype so we can have the executed volumes. 
Adds the datatype where we can save the API information

It also makes use of this data in the recent history. 

## Not included

Saving the actual data.

Co-authored-by: biocom <michel@gnosis.pm>

* Correction of buy/sell prices.

* Close walletModal on connection success

* Orders panel execution price (#1309)

* Fix decimals bug

* Moved additional info to BaseOrder, everything is serializable

* Added additional info to order fullfilment type

* Passing along additional info when fulfillig order

* Storing additional info on order obj

Co-authored-by: Leandro Boscariol <leandro.boscariol@gnosis.io>

Co-authored-by: Leandro Boscariol <leandro.boscariol@gnosis.io>
Co-authored-by: Anxo Rodriguez <anxolin@gmail.com>
Co-authored-by: Leandro Boscariol <alfetopito@users.noreply.github.com>

* Fix price format (#1310)

* Add limit price and valid to/filled date.

* Add limit price and valid to/filled date.

* Fixed type of getLimitPrice utils function

* Execution price WIP.

* Styled file for cleanup.

* Styled file for cleanup.

* Fix grid on mobile (Safari).

* comment out getExecutedPrice

* Expired order strike through.

* Unfillable faq link external.

* Price functions for Recent History (#1289)

* Add bignumber, so library matches our dex-js

* Add price utils

* Refactor transaction summary

* Change todo

* Rename variable to executionPrice.

* Delete comment

* Remove comments and improve doc

* Fix path and default value

* Add datatype for api additional data (#1290)

# Summary

Continues #1289, 

Augment the order datatype so we can have the executed volumes. 
Adds the datatype where we can save the API information

It also makes use of this data in the recent history. 

## Not included

Saving the actual data.

Co-authored-by: biocom <michel@gnosis.pm>

* Correction of buy/sell prices.

* Close walletModal on connection success

* fix price format

* Clean console.log

* Clean console.log

* Price invert fix.

* Orders panel execution price (#1309)

* Fix decimals bug

* Moved additional info to BaseOrder, everything is serializable

* Added additional info to order fullfilment type

* Passing along additional info when fulfillig order

* Storing additional info on order obj

Co-authored-by: Leandro Boscariol <leandro.boscariol@gnosis.io>

* Style execution price.

* Fix transaction style for longer digits.

Co-authored-by: Leandro Boscariol <leandro.boscariol@gnosis.io>
Co-authored-by: Anxo Rodriguez <anxolin@gmail.com>
Co-authored-by: Leandro Boscariol <alfetopito@users.noreply.github.com>

* Price out of market iteration 2. (#1346)

* Fix Safari sidebar style issue.

Co-authored-by: Anxo Rodriguez <anxolin@gmail.com>
Co-authored-by: David <david.sato64@gmail.com>
Co-authored-by: Leandro Boscariol <leandro.boscariol@gnosis.io>
Co-authored-by: Leandro Boscariol <alfetopito@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants