Fix mypy for local chain tests

[kongzii]

No description provided.

[coderabbitai]

Walkthrough

The changes involve modifications to how private keys are handled within the testing framework. Specifically, the private_key_type has been introduced to ensure that private keys are validated and wrapped appropriately in the test_keys function and the test_wont_retry function. This aims to enhance type safety and consistency in private key management across the test suite.

Changes

Files	Change Summary
tests_integration_with_local_chain/conftest.py, tests_integration_with_local_chain/markets/omen/test_contract.py	Introduced private_key_type for improved handling of private keys. Updated test_keys and test_wont_retry functions to use this type.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 74c7e0f and 57b0591.

Files ignored due to path filters (1)

• mypy.ini is excluded by !**/*.ini

Files selected for processing (2)

• tests_integration_with_local_chain/conftest.py (2 hunks)
• tests_integration_with_local_chain/markets/omen/test_contract.py (2 hunks)

Additional comments not posted (4)

tests_integration_with_local_chain/conftest.py (2)

11-11: Approved new import for private_key_type.

The import of private_key_type is correctly placed and necessary for the changes in the test_keys function.

---

41-43: Review the usage of private_key_type in test_keys.

The test_keys function now wraps the private_key with private_key_type, which should help in enforcing type safety and consistency. This change is crucial for meeting the PR's objectives of enhancing type safety in the test suite.

tests_integration_with_local_chain/markets/omen/test_contract.py (2)

8-12: Approved the updated import statements.

The addition of ChecksumAddress and private_key_type to the imports is necessary for the changes made in the test_wont_retry function. These imports enhance clarity and type safety.

---

117-119: Review the enhanced private key handling in test_wont_retry.

The test_wont_retry function now uses private_key_type to wrap the private key before passing it to the APIKeys constructor. This change is consistent with the rest of the codebase and enhances type safety.