Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

[Deployment Screen] Design #242

Closed
lukasschor opened this issue Nov 5, 2019 · 13 comments
Closed

[Deployment Screen] Design #242

lukasschor opened this issue Nov 5, 2019 · 13 comments
Assignees
Labels
Major Needs to be fixed for immediate next public release.

Comments

@lukasschor
Copy link
Member

lukasschor commented Nov 5, 2019

Story:
As a user deploying a new Safe I want to be better informed about the Safe deployment status so that I don't have to worry whether the deployment is going to be successful or not.

Screenshot 2019-11-05 at 18.06.41.png

Improvement ideas:

  • Don't show the screen above before deployment transaction has been identified. Rather show a screen saying something like "Please confirm the creation in your wallet" and the opportunity to "try again" in case for example Metamask had issues and didn't ask the user to sign the creation transaction (This should also address Handle user rejections for metamask/safe-extension transactions #111 )
  • Show progress bar when deployment transaction has been identified
  • More descriptive "finite" progress bar (can also be faked with an estimate)
  • Give opportunity to follow progress on Etherscan
  • More "entertaining" screen as it takes a while for the Safe deployment to finish and depending on network congestion like 1) An animated Safe visual or some education about the USPs of the Safe) 2) some apps use the pattern of just displaying (more or less random) activities that are done in the background and that switch every 5-10 seconds. This could for example be (Transaction submitted...``Validating transaction... -> Deploying smart contract... -> Generating your Safe... -> Setting up access policy... -> Waiting for confirmation on the blockchain...)
@lukasschor lukasschor added this to the Safe for Teams v4.0.0 (New Year Features) milestone Nov 5, 2019
@lukasschor lukasschor self-assigned this Nov 5, 2019
@lukasschor lukasschor modified the milestones: Safe for Teams v1.6.0 (All about Smart Contracts), Safe for Teams v1.5.0 (Transaction Context) Dec 4, 2019
@lukasschor lukasschor added Design Major Needs to be fixed for immediate next public release. labels Dec 5, 2019
@lukasschor lukasschor removed their assignment Dec 11, 2019
@lukasschor lukasschor removed this from the Safe for Teams v1.5.0 (Transaction Context) milestone Jan 8, 2020
@pablofullana
Copy link

Couple of questions here:

  1. We have developed and currently support POA's Bridge which has a nice progress display feature. Shall we plan on implementing something similar?
  2. Extra: Keep track of progress and ship a 'resume' feature? (if possible)

@fernandomg fernandomg assigned fernandomg and unassigned fernandomg Feb 3, 2020
@fernandomg
Copy link
Contributor

This was discussed with @lukasschor: we'll keep the following approach:

More "entertaining" screen as it takes a while for the Safe deployment to finish and depending on network congestion like 1) An animated Safe visual or some education about the USPs of the Safe) 2) some apps use the pattern of just displaying (more or less random) activities that are done in the background and that switch every 5-10 seconds. This could for example be (Transaction submitted...``Validating transaction... -> Deploying smart contract... -> Generating your Safe... -> Setting up access policy... -> Waiting for confirmation on the blockchain...)

@alongoni, FYI

@alongoni
Copy link
Contributor

Hi @lukasschor , we define 6 steps that give to the user more information about the Safe deployment status.

We use a variant of the 3 steps for creating a new Safe. Intentionally the 6 steps on the left don`t expand. This will improve the usability because all the steps are visible in all the proccess.

If you are agree whith the design, I'll continue all steps.

Create New Safe v2 - step 1

Create New Safe v2 – step 2

Create New Safe v2 – step 3

Create New Safe v2 – step 4

Create New Safe v2 – step 4 error

cc: @fernandomg

@lukasschor
Copy link
Member Author

I like this approach a lot. Let's add to the first step also this grey bar, saying "Please confirm the Safe creation in your wallet". And have a Retry button below (center-aligned).

image.png

Error state

image.png

Let's call the "Abort" button "Cancel" and have both center-aligned to be more in line with other parts of the interface.

@alongoni
Copy link
Contributor

@lukasschor, this are all steps:

Create New Safe v2 - step 1

Create New Safe v2 – step 2

Create New Safe v2 – step 3

Create New Safe v2 – step 4

Create New Safe v2 – step 4 error

Create New Safe v2 – step 5

Create New Safe v2 – step 6

Create New Safe v2 – success

cc @fernandomg

@fernandomg
Copy link
Contributor

@alongoni, what about the last step. Shall we leave it for a few seconds and then redirect the user to the newly created Safe or add a button to navigate to it?

@alongoni
Copy link
Contributor

alongoni commented Feb 18, 2020

@fernandomg. In my opinion I think that we shall leave it a few second. It's consitentent with the previous interaction pattern. Lukas, what do you think?

@lukasschor
Copy link
Member Author

lukasschor commented Feb 18, 2020

Yes I would leave for 3 seconds, I would also use the checkmark illustration we use here for the last step: https://zpl.io/bP84XDD

@alongoni
Copy link
Contributor

Great! Create New Safe v2 – success

@lukasschor
Copy link
Member Author

Gather some feedback within the office. Some insights contradict opinions I had earlier, so sorry about that.

Could we use the same grey background as with the error message and say

  • Step 2-5 "Please do not leave the page"
  • Step 6 "Click below to get started"

Use a button for step 6 "Continue", no need to show a link to etherscan in this step

Rename Step 6 in the progress bar to "Success" and leave out the "Waiting for confirmation on blockchain" screen.

For steps 2-5 there should always be something moving on the screen. Either just using some dots "..." or have a loading spinner (e.g. in the progress bar on the left side). This would help the user understand that he does not need to take any action.

@lukasschor
Copy link
Member Author

Also, would it be possible to provide feedback on another tool than Github issues? e.g. Invision, or maybe Figma has a design review feature? The friction would be much lower to give feedback and link comments directly to parts of the screen.

@alongoni
Copy link
Contributor

@lukasschor Here is the design in Figma, you can give feedback there.
https://www.figma.com/proto/9Kscp4DhKRttHBHMocOBuy/Gnosis-Safe?node-id=13%3A768&scaling=min-zoom

@lukasschor
Copy link
Member Author

Nice! In the first screen the card background is a bit off compared to the other ones, but no need to change it in figma as long as the dev implementing it won't implement it 1:1. :)

Looks very good!

@fernandomg fernandomg changed the title Improve Safe Deployment Screen [Deployment Screen] Design Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Major Needs to be fixed for immediate next public release.
Projects
None yet
Development

No branches or pull requests

4 participants