Add ligature Support #104
Add ligature Support #104
Conversation
|
if that's an expected behavior?
|
|
@actionless works fine,
|
|
We'll want to make this opt-in through xresources, and consider notifying package maintainers of the new dependency |
|
@arkhan you didn't got my example -- it not works when between symbols are invisible escape sequences for defining the color of the letters |
|
@actionless I see on the patch page:
|
|
@actionless like this:
|
st.c
Outdated
| @@ -2719,7 +2719,8 @@ draw(void) | |||
| drawregion(0, 0, term.col, term.row); | |||
| if (term.scr == 0) | |||
| xdrawcursor(cx, term.c.y, term.line[term.c.y][cx], | |||
| term.ocx, term.ocy, term.line[term.ocy][term.ocx]); | |||
| term.ocx, term.ocy, term.line[term.ocy][term.ocx], | |||
| term.line[term.ocy], term.col); | |||
st.h
Outdated
| @@ -34,6 +35,7 @@ enum glyph_attribute { | |||
| ATTR_WIDE = 1 << 9, | |||
| ATTR_WDUMMY = 1 << 10, | |||
| ATTR_BOXDRAW = 1 << 11, | |||
| ATTR_LIGA = 1 << 12, | |||
| @@ -1287,7 +1291,7 @@ xmakeglyphfontspecs(XftGlyphFontSpec *specs, const Glyph *glyphs, int len, int x | |||
| mode = glyphs[i].mode; | |||
|
|
|||
| /* Skip dummy wide-character spacing. */ | |||
| if (mode == ATTR_WDUMMY) | |||
| if (mode & ATTR_WDUMMY) | |||
There was a problem hiding this comment.
the question above still valid
i think this is still a blocker for this PR to be merged |
|
Breaks boxdraw. |
|
why you did closed it? |
|
@actionless Unfortunately I find myself difficult of time to review the problems to be solved in this MR |
No description provided.