fixed codecov so it actually works

[Saynkas]

No description provided.

[codecov]

Codecov Report

Patch coverage: 37.93% and project coverage change: -0.67 ⚠️

Comparison is base (c94e31c) 41.83% compared to head (a995acc) 41.17%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1601      +/-   ##
==========================================
- Coverage   41.83%   41.17%   -0.67%     
==========================================
  Files         347      354       +7     
  Lines      108284    94717   -13567     
  Branches        0    19437   +19437     
==========================================
- Hits        45297    38995    -6302     
+ Misses      62987    55722    -7265     

Impacted Files	Coverage Δ
src/FMTIn.cpp	15.81% <ø> (-1.49%)	⬇️
src/FMTIn.hpp	47.61% <ø> (+2.16%)	⬆️
src/FMTLexer.hpp	100.00% <ø> (ø)
src/FMTOut.cpp	43.79% <ø> (+0.86%)	⬆️
src/FMTOut.hpp	77.35% <ø> (+4.63%)	⬆️
src/FMTParser.hpp	50.00% <ø> (+27.77%)	⬆️
src/GDLInterpreter.hpp	49.23% <ø> (-0.14%)	⬇️
src/GDLLexer.hpp	59.09% <0.00%> (+4.74%)	⬆️
src/GDLParser.cpp	66.09% <ø> (-4.57%)	⬇️
src/GDLParser.hpp	75.00% <ø> (+0.92%)	⬆️
... and 79 more

... and 251 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[slayoo]

@Saynkas Thanks!
The CI status is "red" due to codecov and (unrelated) windows build errors.
How to interpret the codecov failures?

[Saynkas]

@Saynkas Thanks! The CI status is "red" due to codecov and (unrelated) windows build errors. How to interpret the codecov failures?

it seems that codecov doesn't like the overall coverage % dropping below what it was before (not too unexpected, the goal is to go towards 100% coverage, not 0%, and codecov had been out of service for 5 months so the code changed since then)

apparently you can specify a threshold to allow the codecov checks to not fail (eg if the threshold is 10% then the overall % can drop by 10% and not count as 'failed'), and by default it compares to the latest commit's %

should I edit the .yml to account for this, and if so, what threshold value should I use ?

taken from https://docs.codecov.com/docs/commit-status

[slayoo]

Thanks for clarifying - IIUC, after merging we do want to block PRs lewering the coverage ratio - merging!