Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1724: WIDGET_SLIDER with TITLE crashes when setting value #1729

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

frankmri
Copy link
Contributor

No description provided.

@frankmri
Copy link
Contributor Author

Hi, this may not be the right way to fix this, in this case just use it as a pointer to the culprit, best, Frank.

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (8157c12) 42.06% compared to head (94b2bab) 42.05%.

Files Patch % Lines
src/gdlwidget.cpp 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1729      +/-   ##
==========================================
- Coverage   42.06%   42.05%   -0.01%     
==========================================
  Files         361      361              
  Lines       96391    96399       +8     
  Branches    19802    19805       +3     
==========================================
  Hits        40543    40543              
- Misses      55848    55856       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GillesDuvert
Copy link
Contributor

Thanks @frankmri Will merge this hopefully soon now.
Congrats, this was not easy... We do not have so many contributors, especially handy with wxWidgets... 😄 .. and C++ ... 😄 ... Thanks again.

@GillesDuvert GillesDuvert merged commit 645682f into gnudatalanguage:master Jan 23, 2024
6 of 8 checks passed
@frankmri
Copy link
Contributor Author

Thank you @GillesDuvert for including this!
Best

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants