nautilus: Add compatibility with Nautilus 43 #2115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't needed since https://gitlab.gnome.org/GNOME/nautilus-python/-/commit/8c88de8da42 And interferes with being able to use this extension on Nautilus 43+
|
For the CI, Debian Testing is known to be broken (tilix is currently unbuildable there). Sorry. |
|
There were some fixes pushed to Debian but it will probably take 5 or 6 days for them to migrate to Debian Testing. |
jtojnar
reviewed
Sep 6, 2022
|
Looks good to me! |
jtojnar
reviewed
Sep 6, 2022
|
Here's the documentation: https://gnome.pages.gitlab.gnome.org/nautilus-python/nautilus-python-migrating-to-4.html |
Nautilus 43 and nautilus-python 4 have made major changes to the API Nautilus.LocationWidgetProvider has been dropped from the API without a replacement https://gnome.pages.gitlab.gnome.org/nautilus-python/nautilus-python-migrating-to-4.html
|
yay, Debian Testing is fixed and the CI is passing again. |
|
Awesome, thank you for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nautilus 43 and nautlius-python 4 introduce major changes to the extension API. (Nautilus 43 also was ported to GTK4.)
The GNOME 43 Release Candidate is being released in the next few days and the stable release will happen on September 21.
I guess this merge proposals breaks the keyboard shortcut for Nautilus > Open in Tilix. (By the way, Ubuntu Desktop uses Ctrl+Alt+T for their systemwide Launch a Terminal feature.)