Fix compilation error due to std.xml deprecation #2160
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
std.xml has been deprecated [1] and removed [2] from the standard library, therefor compilation failed due to the missing package. As a temporary fix, add the undeaD package and use the xml library from it for the time being. Fix gnunn1#2152 [1] https://dlang.org/changelog/2.092.0.html#deprecate-xml [2] https://dlang.org/changelog/2.101.0.html#remove-std-xml
|
This patch doesn't work for Meson (which in turn is what pretty much all Linux distros use to build Tilix), and relying on undeaD is, well, a dead end ;-) - and another dependency for people using Tilix to package. I've updated the code to not rely on std.xml and use GMarkup instead. |
|
Make sense, looking for another library was the next step, I will look what you have done, and use Meson myself, and see if the README could be updated too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std.xml has been deprecated [1] and removed [2] from the standard library, therefor compilation failed due to the missing package.
As a temporary fix, add the undeaD package and use the xml library from it for the time being.
Fix #2152
[1] https://dlang.org/changelog/2.092.0.html#deprecate-xml
[2] https://dlang.org/changelog/2.101.0.html#remove-std-xml