-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grpython use posix prefix scheme #5739
grpython use posix prefix scheme #5739
Conversation
Recently in Debian's pthon3.10 the default scheme for sysconfig changed from 'posix_prefix' to 'posix_local'. GrPython.cmake expects the 'posix_prefix' behavior. So explicity use it. Signed-off-by: A. Maitland Bottoms <bottoms@debian.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since prefix_posix
is the default scheme
https://docs.python.org/3/library/sysconfig.html#installation-paths
and we are not currently specifying a scheme, this seems safe.
@ryanvolz can you verify that this is ok for Windows, since there are separate schemes listed for nt.
Hmm, clearly there are no issues with the conda builds because the recipe sets GR_PYTHON_PATH (and that's still true for the conda-forge packages), so I don't expect to personally see any problems because of this change. But I do wonder about other theoretical Windows users since this does change the default scheme from "nt" to "posix_prefix" in that case. (It looks like there will be a new scheme option with Python 3.11 that would do what @mait wants but also keep the nt scheme on Windows, "venv", but obviously it would be a while until we could use that.) Maybe a ternary expression like |
Since Ubuntu 22.04 is using Python 3.10, this patch is pretty much necessary now. Otherwise, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on Ubuntu 22.04.
Let's go ahead and merge this on |
Recently in Debian's pthon3.10 the default scheme for sysconfig
changed from 'posix_prefix' to 'posix_local'. GrPython.cmake
expects the 'posix_prefix' behavior. So explicity use it.
Signed-off-by: A. Maitland Bottoms bottoms@debian.org
name: grpython use posix prefix scheme
about: GrPython.cmake
title: ''
labels: ''
assignees: ''
Pull Request Details
Description
Install path changed to /usr/local with python3.10 - even though the desire
is to set the install directories using gnuradio's cmake paths.
Related Issue
Debian bug:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1008854
Which blocks/areas does this affect?
Not only gnuradio itself - but every OOT project that inherits GrPython.cmake.
Testing Done
Debian builds as part of the python3.10-default transition.
Checklist