cpu_features: Update submodule pointer #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have 3 issues that should be fixed with this commit. Fix gnuradio#428 Should be fixed because cpu_features detects `arm64` now. Thus, it builds on MacOS and reports M1 capabilities. Fix gnuradio#478 Fix gnuradio#484 cpu_features received quite a bit of contributions for FreeBSD. All the issues we had should be fixed now. However, this might require further evaluation. Signed-off-by: Johannes Demel <demel@uni-bremen.de>
We don't need cpu_features tests. We are a consumer. Signed-off-by: Johannes Demel <demel@uni-bremen.de>
cpu_features renamed `BUILD_PIC` to `CMAKE_POSITION_INDEPENDENT_CODE`. Let's add that one too. Signed-off-by: Johannes Demel <demel@uni-bremen.de>
michaelld
approved these changes
Dec 23, 2021
Alesha72003
pushed a commit
to Alesha72003/volk
that referenced
this pull request
May 15, 2024
cpu_features: Update submodule pointer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have 3 issues that should be fixed with this commit.
Fix #428
Should be fixed because cpu_features detects
arm64now. Thus, VOLK builds with cpu_features on MacOS and reports M1 capabilities.Fix #478
Fix #484
cpu_features received quite a bit of contributions for FreeBSD. All the issues we had should be fixed now. However, this might require further evaluation.