Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release script improvements #751

Merged
merged 3 commits into from
Feb 9, 2024
Merged

Release script improvements #751

merged 3 commits into from
Feb 9, 2024

Conversation

ZeroChaos-
Copy link
Contributor

@ZeroChaos- ZeroChaos- commented Jan 30, 2024 •
edited
Loading

mostly shellcheck shellcheck but also a bit from me
Closes: #748

@ZeroChaos- ZeroChaos- mentioned this pull request Jan 30, 2024
Closed
@argilo
Copy link
Member

argilo commented Jan 30, 2024

At a glance, the changes look good to me.

Could you add a signoff (git commit --amend -s) and push so that the DCO passes?

@ZeroChaos-
Copy link
Contributor Author

this needs a little testing, don't merge yet please

@ZeroChaos-
Copy link
Contributor Author

tested and safe to merge from my side.

@ZeroChaos- ZeroChaos- force-pushed the release_script_fix branch 2 times, most recently from 93c64e1 to 9298be8 Compare January 30, 2024 20:47
@ZeroChaos-
Copy link
Contributor Author

okay, my changes seem sane and are tested but I can't make the DCO check happy. Can someone please point out my failure so I can fix it right?

@ZeroChaos-
Copy link
Contributor Author

it requires my gentoo email because I signed with that key maybe?

@ZeroChaos-
shellcheck fixes
58c784b 
Conditionalize use of signify-openbsd
Closes: gnuradio#748
Signed-off-by: Rick Farina (Zero_Chaos) <zerochaos@gentoo.org>
@jdemel
Copy link
Contributor

jdemel commented Jan 30, 2024

The DCO check is happy now. That's great.

@marcusmueller
Copy link
Member

Doesn't work for me:

ls: cannot access '/tmp/tmp.27l7Gm7mBG/volk-3.1.1-sub*.tar': No such file or directory

@ZeroChaos-
Copy link
Contributor Author

Doesn't work for me:

ls: cannot access '/tmp/tmp.27l7Gm7mBG/volk-3.1.1-sub*.tar': No such file or directory

if possible, please grab the whole output from sh -x ./scripts/tools/release.sh and paste it here. I can make some guesses but seeing it all may help.

@ZeroChaos-
Copy link
Contributor Author

I pushed a cleaner version of that, please test the latest rev and provide the requested output if it fails.

@marcusmueller
Copy link
Member

oops, this was unintended :D

@marcusmueller
scripts/release: fix multi-concatenation of submodule tars
e322a81 
also, add early exit on existing new or missing old tag

Signed-off-by: Marcus Müller <mmueller@gnuradio.org>
@ZeroChaos-
bash negative exit codes are not portable, let's be positive
1a8ddd5 
Signed-off-by: Rick Farina (Zero_Chaos) <zerochaos@gentoo.org>
@jdemel
Copy link
Contributor

jdemel commented Feb 9, 2024

Thanks everyone for testing and the updates!

@jdemel jdemel merged commit a75556f into gnuradio:main Feb 9, 2024
2 checks passed
Alesha72003 pushed a commit to Alesha72003/volk that referenced this pull request May 15, 2024
@jdemel
Merge pull request gnuradio#751 from ZeroChaos-/release_script_fix
9aa3965 
Release script improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

release script should switch to bash syntax completely
4 participants
@ZeroChaos- @argilo @jdemel @marcusmueller