Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `aah migrate` command to fix/upgrade application codebase to latest aah version #116

Closed
jeevatkm opened this issue Sep 9, 2017 · 6 comments
Assignees
Labels
Projects

Comments

@jeevatkm
Copy link
Member

@jeevatkm jeevatkm commented Sep 9, 2017

The goal is to bring aah migrate command to easy the upgrade or fix the aah framework breaking changes and deprecated elements in .go files and basic template file support.

Limitation:
To begin with migrate command does not support config files; it should be done manually, later I will add it.

  • Implementation
  • Documentation
@jeevatkm jeevatkm added this to Backlog in aah Roadmap Sep 9, 2017
@julienkosinski

This comment has been minimized.

Copy link

@julienkosinski julienkosinski commented Sep 19, 2017

@jeevatkm About config file, when you'll add it update template directly with new config and comments (because config file are always really well commented) with an auto-merging process (like git could do with pulling commits).

For resolving conflicts some of them could modify the project with find/replace. I'm thinking of something like obvious typo change in API...
For all the complexe changes to make I'm thinking of logging in CLI each modifications and actions required and modify the file in which an action is required adding comments in the problematic line to help resolve the problem (maybe the same comments logged in CLI)

@jeevatkm

This comment has been minimized.

Copy link
Member Author

@jeevatkm jeevatkm commented Sep 19, 2017

@julienkosinski That's good suggestion. I agree, logging information via CLI would be helpful.

@julienkosinski

This comment has been minimized.

Copy link

@julienkosinski julienkosinski commented Sep 24, 2017

@jeevatkm Also, as config files updates regularly with new versions to update documentations, efforts could be made about this.

I know that (learn just now in fact), for example, modern javascript front-end scaffolding apps handle this by avoiding default config and providing config repo kept up-to-date with best-practices for each use cases. (See POI, here, here for example).

I suppose in this case the best way is to design the upgrade tool so that it merges config file but having a repo for config is not stupid because there's multiple config use cases to handle (and the created app needs to keep the info of what type of app it is and updates it accordingly, is it web or api, form or basic, etc).

What's your thought about this :)?

@jeevatkm

This comment has been minimized.

Copy link
Member Author

@jeevatkm jeevatkm commented Oct 6, 2017

@julienkosinski I have read and went through your references of config templates idea. Looks interesting.

I will have to do analysis and homework on config template to see; it is feasible to accommodate in aah and Go. Will get back to you.

I would like to do proper homework before touching migrate command implementation.

@jeevatkm jeevatkm self-assigned this May 25, 2018
@jeevatkm jeevatkm added this to the v0.11.0 Milestone milestone May 25, 2018
@jeevatkm jeevatkm moved this from Backlog to v0.11.0 - In Progress in aah Roadmap May 25, 2018
jeevatkm added a commit to go-aah/tools that referenced this issue May 26, 2018
@jeevatkm

This comment has been minimized.

Copy link
Member Author

@jeevatkm jeevatkm commented May 26, 2018

Implementation is done (I would call it beta to begin with; gradually it will get more mature).

Have to work in documentation 😄

jeevatkm added a commit to go-aah/docs that referenced this issue May 27, 2018
@jeevatkm

This comment has been minimized.

Copy link
Member Author

@jeevatkm jeevatkm commented May 27, 2018

Its finally done, thank you for patience.

@jeevatkm jeevatkm closed this May 27, 2018
aah Roadmap automation moved this from v0.11.0 - In Progress to v0.11.0 - Completed May 27, 2018
@jeevatkm jeevatkm moved this from v0.11.0 - Completed to Released to Audience in aah Roadmap Jul 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
aah Roadmap
  
Released to Audience
2 participants
You can’t perform that action at this time.