Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DNS challenge support for namecheap #150

Closed
wants to merge 0 commits into from
Closed

Add DNS challenge support for namecheap #150

wants to merge 0 commits into from

Conversation

beevik
Copy link
Contributor

@beevik beevik commented Mar 10, 2016

This PR adds DNS challenge support for namecheap.

If you decide to accept this PR, please feel free to delay merging it until the changes being made in #144 are complete.

@xenolf
Copy link
Member

xenolf commented Mar 11, 2016

Thank you for this :)

I hope to be able to land #144 soon(tm) now that I've got a bit more time on my hands.

@xi2
Copy link
Contributor

xi2 commented Mar 11, 2016

Hi beevik. I had a quick read through of your code and I wasn't 100% sure it handles TLDs containing a period correctly (such as co.uk or or org.uk). What made me wonder is that given the domain example.co.uk, the splitDomain function would return "co", "uk", nil when I'd imagine it should return "example", "co.uk", nil. These values are then sent through to namecheap.domains.dns.getHosts as SLD and TLD. Am I missing something?

For an alternative way to get TLD and SLD, you can see how I do it in #133 by chopping bits off the front of the FQDN until I hit something that the provider acknowledges, or I believe you can do it by querying nameservers which is what #142 is about?

@beevik
Copy link
Contributor Author

beevik commented Mar 11, 2016

Ah good catch. I just added code to fix this bug. I decided to use a namecheap API to help determine the TLD/SLD.

@xi2
Copy link
Contributor

xi2 commented Mar 11, 2016

Ah cool. That's a nice way of doing it.

We'll see what @xenolf thinks is best for #148, and then we can both change our code accordingly for the timeout issue.

@xenolf
Copy link
Member

xenolf commented Mar 14, 2016

Hey @beevik! Could you please rebase this PR onto current master and move your provider into lego/providers/dns/namecheap. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants